Repository navigation
Background work: scripts and job-owned subagents from background jobs - #196
Merged
Merged
Conversation
… jobs User decisions: - Port the desktop activity pill's background-job behavior to Android
User decisions: - Fix the failing Android unit tests on the pill port
Always report the jobs list, reapply job updates that race it, cancel the read on leave, stop rows concurrently with feedback, scope job updates to the screen's family, seed pushed subagents, desktop section order, TalkBack Stop on script rows, parity notes and tests. Not built locally; CI runs check. User decisions: - Fix the review findings on the Android pill port
From anomalyco/opencode-ios#355 (dec2b938, e1518739, 4fcdc9cb, f9beb70c): - With only scripts running the capsule shows the plain busy orb, as the desktop's chip does; script rows keep </>. - A script's first line truncates at its end; shells keep middle truncation. - Move to Background lists jobs too, so a moved script shows at once. - A job is kept when its owner or the session that started it is in the tree. - Switch snapshots keep their tree's jobs through job.updated and restore them. - A family pick clears pending Stops; an empty jobID never names a script. - Tests: a settle missed while the stream was down is gone after the reconnect's re-list; events during that list win over its stale answer. Verified: :feature:session and :feature:drawer JVM unit tests pass (1383), except 9 Robolectric native tests that can't load on this musl box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the desktop activity pill's background-job behavior (anomalyco/opencode#64790) to the background-work capsule.
GET /api/experimental/job?sessionID&descendants=true&status=runningon open/switch, resume and reconnect; thenexperimental.job.updatedevents. No polling.codemodejobs show as "N scripts" with a row (first line of the script or the job id, elapsed) and Stop →POST /api/experimental/job/:id/cancel.subagentjob counts for itschildSessionID). Its new Stop interrupts it if running and cancels every running job in its tree.Draft: not built or run on a device here (no JDK/Android SDK on the box); CI runs
scripts/check.sh. Strings translated withscripts/translate.py.